Skip to content

Add SECURITY and TOPOLOGY notification categories #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 12, 2023
Merged

Add SECURITY and TOPOLOGY notification categories #1490

merged 4 commits into from
Oct 12, 2023

Conversation

injectives
Copy link
Contributor

No description provided.

@injectives injectives force-pushed the feature/notifications branch from c44dd1d to 8c880e9 Compare October 11, 2023 15:32
bigmontz
bigmontz approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔇

(I think we need some tests for this, especially for checking if the new categories are not treated as unknown when deserialised)

@injectives
Copy link
Contributor Author

We currently rely on the Testkit, which has a pretty good coverage.

robsdedude
robsdedude approved these changes Oct 12, 2023
View reviewed changes
@injectives
Copy link
Contributor Author

(I think we need some tests for this, especially for checking if the new categories are not treated as unknown when deserialised)

New tests have been added.

@injectives injectives merged commit 3f78d83 into neo4j:5.0 Oct 12, 2023
@injectives injectives deleted the feature/notifications branch October 12, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigmontz bigmontz bigmontz approved these changes

@robsdedude robsdedude robsdedude approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@injectives @bigmontz @robsdedude