Skip to content

feat(observability): add Javadoc #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

feat(observability): add Javadoc #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions observation/metrics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<description>The Neo4j Java Driver Observation module providing metrics.</description>

<properties>
<javadoc.failOnWarnings>false</javadoc.failOnWarnings>
<maven.deploy.skip>false</maven.deploy.skip>
</properties>

Expand Down Expand Up @@ -50,6 +51,15 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</build>

<scm>
<connection>scm:git:git://github.com/neo4j/neo4j-java-driver.git</connection>
<developerConnection>scm:git:[email protected]:neo4j/neo4j-java-driver.git</developerConnection>
Expand Down
5 changes: 5 additions & 0 deletions observation/micrometer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<micrometer-docs-generator.inputPath>${project.build.sourceDirectory}/org/neo4j/driver/observation/micrometer</micrometer-docs-generator.inputPath>
<micrometer-docs-generator.inclusionPattern>.*</micrometer-docs-generator.inclusionPattern>
<micrometer-docs-generator.outputPath>${project.build.directory}/docs</micrometer-docs-generator.outputPath>
<javadoc.failOnWarnings>false</javadoc.failOnWarnings>
<maven.deploy.skip>false</maven.deploy.skip>
</properties>

Expand Down Expand Up @@ -130,6 +131,10 @@
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
</plugin>
</plugins>
</build>

Expand Down
3 changes: 2 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
<surefire.jpms.args/>
<failsafe.parallelizable.jpms.args/>
<failsafe.sequential.jpms.args/>
<javadoc.failOnWarnings>true</javadoc.failOnWarnings>
<!-- Skip deployment by default for everything in this project. -->
<maven.deploy.skip>true</maven.deploy.skip>

Expand Down Expand Up @@ -604,7 +605,7 @@
<goal>jar</goal>
</goals>
<configuration>
<failOnWarnings>true</failOnWarnings>
<failOnWarnings>${javadoc.failOnWarnings}</failOnWarnings>
</configuration>
</execution>
<execution>
Expand Down