feat(acquisition): apply acquisition timeout to all steps #1685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/acquisition
branch
7 times, most recently
from
e5b59f0 to
ad13ed8
Compare
injectives
changed the title
injectives
force-pushed
the
feature/acquisition
branch
6 times, most recently
from
bf18841 to
629225e
Compare
injectives
changed the title
BREAKING CHANGE: `org.neo4j.driver.Config.ConfigBuilder#withConnectionAcquisitionTimeout(long, TimeUnit)` no longer accepts negative values, matching the handling of `org.neo4j.driver.Config.ConfigBuilder#withConnectionTimeout(long, TimeUnit)`. In addition, the acquisition timeout is applied for the entire connection acquisition process that may include client-side routing and other logic. Previously, the connection acquisition timeout applied individually per every acquisition from individual connection pool and only when all connections were busy.
injectives
force-pushed
the
feature/acquisition
branch
from
629225e to
ba7b771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
org.neo4j.driver.Config.ConfigBuilder#withConnectionAcquisitionTimeout(long, TimeUnit)no longer accepts negative values, matching the handling oforg.neo4j.driver.Config.ConfigBuilder#withConnectionTimeout(long, TimeUnit). In addition, the acquisition timeout is applied for the entire connection acquisition process that may include client-side routing and other logic. Previously, the connection acquisition timeout applied individually per every acquisition from individual connection pool and only when all connections were busy.