Return an empty stats if no stat is included in summary #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
force-pushed
the
fix-null-stats
branch
from
a0b98c4 to
5d2da91
Compare
|
I'm happy with the code in this PR though I'd like to understand why no summary was included. I though that we should always get one back? Could you please investigate the current behavior of Cypher, i.e. does db.execute(query) always give us update statistics? If so, remoting should behave the same. Or is this an optimization where we choose to not send an empty (all zero) statistics from the server side? |
|
@boggle In other word, if we got no updates, then nothing is sent and on the client we should give them 0s by default. |
|
Looks good! Needs rebase, happy to merge this |
zhenlineo
force-pushed
the
fix-null-stats
branch
from
5d2da91 to
497f802
Compare
Added a test to verify behaviours when empty result summary returned
zhenlineo
force-pushed
the
fix-null-stats
branch
from
497f802 to
2cfd5cf
Compare
zhenlineo
pushed a commit
that referenced
this pull request
Nov 18, 2015
Return an empty stats if no stat is included in summary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.