Allow initial bookmark in session #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it could later use it to obtain connections on demand rather than hold a single connection permanently.
This commit effectively decouples session from connection. Session now holds two `ConnectionHolder`s that lazily pick connection from the pool when it is needed and try to release connection back to the pool when it does not have any users. Session keeps one connection holder for read connection and one for write connection. Connection is acquired for `Session#run()` and released when the returned result is either fully consumed or error happens. Also connection is acquired for `Session#beginTransaction()` and released when transaction commits or rolls back.
This commit adds second parameter `bookmark` to the existing `Driver#session(accessMode)` API function to allow creation of a session with the specified initial bookmark. This means that first transaction in the created session will ensure that the server, it is connected to, is at least up to the database version denoted by the bookmark. Bookmark is a session related concept and this commit adds symmetry with regards to `Session#lastBookmark()` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #215. Only last commit is new.
Commit adds second parameter
bookmarkto the existingDriver#session(accessMode)API function to allow creation of a session with the specified initial bookmark. This means that first transaction in the created session will ensure that the server, it is connected to, is at least up to the database version denoted by the bookmark.Bookmark is a session related concept and this commit adds symmetry with regards to
Session#lastBookmark()method.