Fix streaming of queued records in stream observer #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`StreamObserver` memorizes all incoming records when it does not have a subscriber to forward records to. Later when such subscriber appears it receives all queued records in on go. This functionality did not work properly because of a missing `this` which resulted in access to an undefined variable. This commit fixes the problem and adds some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamObservermemorizes all incoming records when it does not have a subscriber to forward records to. Later when such subscriber appears it receives all queued records in on go.This functionality did not work properly because of a missing
thiswhich resulted in access to an undefined variable. This PR fixes the problem and adds some tests.Fixes #221