Updated examples #229
Merged
Updated examples #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenlineo
approved these changes
Apr 7, 2017
test/v1/examples.test.js
Outdated
| driver.close(); | ||
| }); | ||
| it('basic auth example', done => { | ||
| const user = 'neo4j'; |
There was a problem hiding this comment.
Can we make user, password and uri global variable instead? As we might change them when migrate from neokit to boltkit.
test/v1/examples.test.js
Outdated
| // tag::custom-auth[] | ||
| const driver = neo4j.driver( | ||
| 'bolt://localhost:7687', | ||
| neo4j.auth.custom(principal, credentials, realm, scheme, parameters) |
There was a problem hiding this comment.
Do me missing a test here?
We could still use principle=neo4j, credentials=neo4j, real=local, scheme=basic to use custom auth to pass basic auth to the server.
This commit updates tests that are used in developer manual to highlights recommended API usage and available configuration options.
|
@zhenlineo rebased and addressed comments |
* use constants for user, password and uri * test custom auth with basic auth params
|
LG |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates tests that are used in developer manual to highlights recommended API usage and available configuration options.
Depends on #228 to make
service unavailable exampletest pass.