Fixed timeout when acquiring connection from pool #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connection pool has limited size and returns `Promise<Connection>` instead of `Connection` directly. Returned promise can be failed when connection acquisition timeout has fired. Pool uses helper function `util#promiseOrTimeout()` to race acquisition and timeout promises. This function allowed both timeout callback to be invoked and connection to be acquired. It cleared the timeout outside of the raced promises. As result connection was acquired but timeout callback failed in background. It tried to clear non-existing pending acquisition attempts. This commit fixes the problem by including `#clearTimeout()` call in the chain of raced promises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection pool has limited size and returns
Promise<Connection>instead ofConnectiondirectly. Returned promise can be failed when connection acquisition timeout has fired. Pool uses helper functionutil#promiseOrTimeout()to race acquisition and timeout promises.This function allowed both timeout callback to be invoked and connection to be acquired. It cleared the timeout outside of the raced promises. As result connection was acquired but timeout callback failed in background. It tried to clear non-existing pending acquisition attempts.
This PR fixes the problem by including
#clearTimeout()call in the chain of raced promises.Fixes #304