Skip to content

Pull Results in Batches #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 28, 2019
Merged

Pull Results in Batches #495

merged 5 commits into from
Oct 28, 2019

Conversation

@zhenlineo
Copy link
Contributor

@zhenlineo zhenlineo commented Oct 17, 2019 •
edited
Loading

  • Added fetchSize as an optional configuration option on driver config and session config.
  • Allowed async to pull results in batches.
  • Ensured Transaction#commit and Transaction#rollback to always finish query execution before commit/rollback.
  • Fixed a bug where parameter mode and database shall not be send on RUN message of session run.
  • Fixed some type errors in the type script

@zhenlineo zhenlineo force-pushed the 4.0-pull-in-batches branch from 175ab6c to 78e13b9 Compare October 17, 2019 15:05
@zhenlineo zhenlineo force-pushed the 4.0-pull-in-batches branch from 78e13b9 to 30b689a Compare October 17, 2019 15:06
Zhen Li added 2 commits October 18, 2019 14:28
@zhenlineo zhenlineo force-pushed the 4.0-pull-in-batches branch from 97db791 to 14f073d Compare October 18, 2019 15:23
@zhenlineo zhenlineo changed the title Adding fetchSize as an optional configuration option Pull Results in Batches Oct 18, 2019
@zhenlineo zhenlineo force-pushed the 4.0-pull-in-batches branch from 2ad3878 to 5ccbcf9 Compare October 24, 2019 15:22
@zhenlineo zhenlineo force-pushed the 4.0-pull-in-batches branch from 5ccbcf9 to c945ecc Compare October 25, 2019 15:55
@zhenlineo zhenlineo merged commit a17eee1 into neo4j:4.0 Oct 28, 2019
@zhenlineo zhenlineo deleted the 4.0-pull-in-batches branch October 28, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@zhenlineo