ValueError on invalid connection_acquisition_timeout
#1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `ValueError` on invalid values (instead of `ClientError`) - Consistently restrict the value to be strictly positive
robsdedude
force-pushed
the
errors/value-error-on-invalid-acquisition-timeout
branch
from
a3cbd46 to
5783295
Compare
Signed-off-by: Rouven Bauer <[email protected]>
robsdedude
force-pushed
the
errors/value-error-on-invalid-acquisition-timeout
branch
from
595d626 to
02f55ae
Compare
AndyHeap-NeoTech
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueErroron invalid values (instead ofClientError)