Improve packstream Structure class #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
force-pushed
the
feat/improve-packstream-structure-class
branch
from
d4852e4 to
a4e838e
Compare
These changes have no affect on the driver's public API. They're targeted at improving the development and debugging experience. * Adjust `repr` to follow Python's recommendations * Fix `__eq__` returning `NotImplementedError` instead of `NotImplemented` * Add type hints * Add tests
robsdedude
force-pushed
the
feat/improve-packstream-structure-class
branch
from
a4e838e to
57472bb
Compare
MaxAake
approved these changes
Aug 25, 2025
Great question. Firstly, there are 2 change logs:
The latter is a full changelog with anything that's user-facing. The former is only major and breaking changes. Whatever that means. When I took over maintenance of this project, this was already like that. It might be worth tackling that at some point. Either way, the user should under normal conditions never end up with a |
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Sep 12, 2025
robsdedude
added a commit
to robsdedude/neo4j-python-driver
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have no affect on the driver's public API. They're targeted at improving the development and debugging experience.
reprto follow Python's recommendations__eq__returningNotImplementedErrorinstead ofNotImplemented