Skip to content

fix when testkit sends None for trustedCertificates #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2022
Merged

fix when testkit sends None for trustedCertificates #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
686f4d3
fix when testkit sends None for trustedCertificates
thelonelyvulpes Feb 17, 2022
23c0f8b
Also fix async backend
robsdedude Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions testkitbackend/_async/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,12 @@ async def NewDriver(backend, data):
if "encrypted" in data:
kwargs["encrypted"] = data["encrypted"]
if "trustedCertificates" in data:
kwargs["trusted_certificates"] = [
"/usr/local/share/custom-ca-certificates/" + cert
for cert in data["trustedCertificates"]
]
kwargs["trusted_certificates"] = data["trustedCertificates"]
if isinstance(kwargs["trusted_certificates"], list):
kwargs["trusted_certificates"] = [
"/usr/local/share/custom-ca-certificates/" + cert
for cert in kwargs["trusted_certificates"]
]

data.mark_item_as_read("domainNameResolverRegistered")
driver = neo4j.AsyncGraphDatabase.driver(
Expand Down
10 changes: 6 additions & 4 deletions testkitbackend/_sync/requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,12 @@ def NewDriver(backend, data):
if "encrypted" in data:
kwargs["encrypted"] = data["encrypted"]
if "trustedCertificates" in data:
kwargs["trusted_certificates"] = [
"/usr/local/share/custom-ca-certificates/" + cert
for cert in data["trustedCertificates"]
]
kwargs["trusted_certificates"] = data["trustedCertificates"]
if isinstance(kwargs["trusted_certificates"], list):
kwargs["trusted_certificates"] = [
"/usr/local/share/custom-ca-certificates/" + cert
for cert in kwargs["trusted_certificates"]
]

data.mark_item_as_read("domainNameResolverRegistered")
driver = neo4j.GraphDatabase.driver(
Expand Down