Support serializing datetimes with datetime.timezone #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables users to use python's standard `datetime.timezone` for constant utc-offset timezones (only for serialization, data coming back from the server will continue to use `pytz`). This change also enables pandas 2 as pandas switched over to `datetime.timezone` for constant offset timezones https://pandas.pydata.org/docs/dev/whatsnew/v2.0.0.html#utc-and-fixed-offset-timezones-default-to-standard-library-tzinfo-objects
The driver may not depend on 3rd party libraries when just being loaded. This has to be done dynamically when needed to not break pip install which loads the driver to figure out the version number (and potentially other meta data).
fbiville
approved these changes
Apr 13, 2023
thelonelyvulpes
approved these changes
Apr 13, 2023
Signed-off-by: Rouven Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to use python's standard
datetime.timezonefor constant utc-offset timezones (only for serialization, data coming back from the server will continue to usepytz).This change also enables pandas 2 as pandas switched over to
datetime.timezonefor constant offset timezoneshttps://pandas.pydata.org/docs/dev/whatsnew/v2.0.0.html#utc-and-fixed-offset-timezones-default-to-standard-library-tzinfo-objects