test_name in test_buffer.py fails on OS X

[btipling]

On OS X /var is a symlink to /private/var so the check:

new_name = vim.eval('tempname()')
vim.current.buffer.name = new_name
eq(vim.current.buffer.name, new_name)

fails with:

AssertionError: '/private/var/folders/07/jtkf72yn4_587wv8zc7ntg6h0000gn/T/nvim8XLj27/0' != '/var/folders/07/jtkf72yn4_587wv8zc7ntg6h0000gn/T/nvim8XLj27/0'

Although the file was name was changed the test fails because the symlink path is being used in one case and the full path in the other case.

[tarruda]

We had a similar problem on the lua functional tests a while ago. vim.eval('tempname()') needs to be changed to vim.eval('resolve(tempname())') to fix this error

[btipling]

Yes I've tried that, but vim.command('w!') a few lines down now takes a long time and then the tests just end without completing.

[tarruda]

Events are no longer handled in some states such as "press enter to continue" so this could be a cause for the hang. This is easy to inspect with gdb by attaching to nvim, but unfortunately I don't have access to OSX so you would have to do it yourself

If thats the case, adding vim.input('\r') after the command which causes the "press enter to continue" message should fix it

[btipling]

Current bt while it's stuck is:

(lldb) bt
* thread #1: tid = 0x42667c, 0x000000010be2bd50 nvim`uv__io_poll(loop=0x000000010be73b70, timeout=<unavailable>) + 896 at kqueue.c:169, queue = 'com.apple.main-thread', stop reason = step over
  * frame #0: 0x000000010be2bd50 nvim`uv__io_poll(loop=0x000000010be73b70, timeout=<unavailable>) + 896 at kqueue.c:169
    frame #1: 0x000000010be1d278 nvim`uv_run(loop=0x000000010be73b70, mode=UV_RUN_ONCE) + 344 at core.c:298
    frame #2: 0x000000010be06b8b nvim`loop(run_mode=UV_RUN_ONCE) + 27 at event.c:196
    frame #3: 0x000000010be06a46 nvim`event_poll(ms=-1) + 230 at event.c:122
    frame #4: 0x000000010be0829d nvim`input_poll(ms=-1) + 141 at input.c:194
    frame #5: 0x000000010be0805a nvim`inbuf_poll(ms=-1) + 74 at input.c:210
    frame #6: 0x000000010be07f62 nvim`os_inchar(buf=0x000000010be6bb99, maxlen=69, ms=-1, tb_change_cnt=814) + 258 at input.c:110
    frame #7: 0x000000010bc99f0f nvim`inchar(buf=0x000000010be6bb99, maxlen=207, wait_time=-1, tb_change_cnt=814) + 655 at getchar.c:2495
    frame #8: 0x000000010bc9e963 nvim`vgetorpeek(advance=1) + 7379 at getchar.c:2315
    frame #9: 0x000000010bc9c402 nvim`vgetc + 242 at getchar.c:1394
    frame #10: 0x000000010bc9ec5d nvim`safe_vgetc + 13 at getchar.c:1514
    frame #11: 0x000000010bce767e nvim`wait_return(redraw=0) + 462 at message.c:826
    frame #12: 0x000000010bce2e13 nvim`msg_end + 83 at message.c:2461
    frame #13: 0x000000010bce265d nvim`msg_attr_keep(s=0x000000010be68d10, attr=0, keep=0) + 333 at message.c:198
    frame #14: 0x000000010bce27f0 nvim`msg_attr(s=0x000000010be68d10, attr=0) + 32 at message.c:150
    frame #15: 0x000000010bce70ae nvim`msg_trunc_attr(s=0x000000010be68d10, force=0, attr=0) + 78 at message.c:608
    frame #16: 0x000000010bc89e86 nvim`buf_write(buf=0x00007fb4a3035400, fname=0x00007fb4a2c09460, sfname=0x00007fb4a2c09460, start=2, end=1, eap=0x00007fff5403b620, append=0, forceit=1, reset_changed=1, filtering=0) + 13606 at fileio.c:3576
    frame #17: 0x000000010bc3a3f6 nvim`do_write(eap=0x00007fff5403b620) + 1542 at ex_cmds.c:2233
    frame #18: 0x000000010bc3a4bb nvim`ex_write(eap=0x00007fff5403b620) + 75 at ex_cmds.c:2090
    frame #19: 0x000000010bc51e18 nvim`do_one_cmd(cmdlinep=0x00007fff5403b8e0, sourcing=1, cstack=0x00007fff5403b918, fgetline=0x0000000000000000, cookie=0x0000000000000000) + 11352 at ex_docmd.c:1925
    frame #20: 0x000000010bc4ded1 nvim`do_cmdline(cmdline=0x00007fb4a2c05e00, fgetline=0x0000000000000000, cookie=0x0000000000000000, flags=11) + 2865 at ex_docmd.c:617
    frame #21: 0x000000010bc4ee2a nvim`do_cmdline_cmd(cmd=0x00007fb4a2c05e00) + 42 at ex_docmd.c:289
    frame #22: 0x000000010be0ea52 nvim`vim_command(str=(data = "w!", size = 2), err=0x00007fff5403bf80) + 34 at vim.c:43
    frame #23: 0x000000010bbca3f8 nvim`handle_vim_command(channel_id=1, request_id=164, args=Array at 0x00007fff5403bea0, error=0x00007fff5403bf80) + 344 at msgpack_dispatch.c:1553
    frame #24: 0x000000010be1732d nvim`on_request_event(event=(data = void * = 0x00007fb4a2e005a0, handler = (nvim`on_request_event at channel.c:473))) + 349 at channel.c:480
    frame #25: 0x000000010be06bd2 nvim`process_events_from(queue=0x00007fb4a2c073b0) + 50 at event.c:174
    frame #26: 0x000000010be06d40 nvim`event_process + 16 at event.c:161
    frame #27: 0x000000010bcfe8fe nvim`normal_cmd(oap=0x00007fff5403c5b8, toplevel=true) + 414 at normal.c:493
    frame #28: 0x000000010bcbff83 nvim`main_loop(cmdwin=0, noexmode=0) + 2051 at main.c:759
    frame #29: 0x000000010bcbca48 nvim`main(argc=3, argv=0x00007fff5403c7d8) + 2664 at main.c:544
    frame #30: 0x00007fff920035c9 libdyld.dylib`start + 1

It's bocked on the vim.command('w!') line so an vim.input after this line does not resolve it.

[btipling]

vim.command('silent w!') resolved the issue.

[tarruda]

Strange, I tried to reproduce the steps of test_name using an interactive REPL but it never entered wait_return, could you inspect the message it was passing to msg_trunc_attr in frame 15?

[btipling]

Sure it was:

frame #16: 0x000000010ea720ae nvim`msg_trunc_attr(s=0x000000010ebf3d10, force=0, attr=0) + 78 at message.c:608
   605    s = msg_may_trunc(force, s);
   606
   607    msg_hist_off = TRUE;
-> 608    n = msg_attr(s, attr);
   609    msg_hist_off = FALSE;
   610
   611    if (n)
(lldb) p s
(char_u *) $0 = 0x000000010ebf3d10 "\"/private/var/folders/07/jtkf72yn4_587wv8zc7ntg6h0000gn/T/nvimpgNpX0/0\" [New File] 0 lines, 0 characters written"