Add standard and detailed timers for benchmarking purposes for NEST 2.20.2 #2086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
I: Internal API
hakonsbm
suggested changes
Jul 2, 2021
Contributor
hakonsbm
left a comment
hakonsbm
left a comment
There was a problem hiding this comment.
Doing a grep of the code, I still find some GetKernelStatus('time')/GetKernelStatus("time")/GetKernelStatus()['time'] in documentation and examples. Can you update those as well? Other than that, and my comment below, it looks good.
nestkernel/nestmodule.cpp
Outdated
| void | ||
| NestModule::Cvgidcollection_ivFunction::execute( SLIInterpreter* i ) const | ||
| { | ||
| kernel().connection_manager.sw_construction_connect.start(); |
Contributor
Contributor
Author
|
Good catch, thanks for the review. I addressed the issues that you raised. |
hakonsbm
approved these changes
Jul 8, 2021
Contributor
hakonsbm
left a comment
hakonsbm
left a comment
There was a problem hiding this comment.
Thanks, looks good now.
Contributor
|
@ackurth: friendly ping! |
Contributor
|
I ran a larger number of benchmarks, everything looked fined. |
ackurth
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timer functionality to NEST 2.20.2. The usage and functionality is similar to what is implemented in PR #1778 and #2063 and addresses the issues raised in #1471.
These timers are implemented:
time_construction_create(basic timer, always enabled)time_construction_connect(basic timer, always enabled)time_simulate(basic timer, always enabled)time_simulate:time_updatetime_gather_spike_datatime_gather_spike_data:time_collocate_spike_datatime_communicate_spike_datatime_deliver_spike_datatime_communicate_prepare(basic timer, always enabled)time_communicate_prepare:time_gather_target_datatime_gather_target_data:time_communicate_target_data