Skip to content

Conversation

@kalmanbendeguz
Copy link
Contributor

HttpException cannot be instantiated with zero arguments. The provided first example is misleading.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Documentation correction

What is the current behavior?

There is a misleading example of the usage of HttpException's constructor. It cannot be instantiated with zero arguments.

Issue Number: N/A

What is the new behavior?

Removed incorrect example.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

HttpException cannot be instantiated with zero arguments. The provided first example is misleading.
@coveralls
Copy link

Pull Request Test Coverage Report for Build d103178f-0b6d-4886-8054-4751bb574b9f

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.16%

Totals Coverage Status
Change from base Build 3bdf7d9b-d77b-45e6-ae7c-043c1979ed39: 0.0%
Covered Lines: 6736
Relevant Lines: 7309

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit c50eb48 into nestjs:master Feb 19, 2024
@kamilmysliwiec
Copy link
Member

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants