Bug: deploy command regression

[DavidWells]

The netlify deploy command used to deploy one of my sites has stopped working in netlify-cli@2.48.0

The command netlify deploy fails with a "Base directory does not exist" error.

> netlify deploy -p --dir public

Base directory does not exist: /Users/davidwells/David/analytics-project/analytics/site/main/site

Was something changed recently with the netlify deploy command?

This is the site in question: https://github.com/DavidWells/analytics/tree/master/site/main and the previously working deploy script is here: https://github.com/DavidWells/analytics/blob/master/site/main/package.json#L14

[DavidWells]

It looks like this is an error coming from netlify/config https://github.com/netlify/build/blob/b6006915061ecd890a7d4f8b857cddc22e778f1a/packages/config/src/files.js#L65 cc @ehmicky

[DavidWells]

Reverting to netlify-cli@2.40.0 fixes this error

[ehmicky]

Just to confirm, I think the error message should be Base directory does not exist: /Users/davidwells/David/analytics-project/analytics/site/main/public, not Base directory does not exist: /Users/davidwells/David/analytics-project/analytics/site/main/site if you passed --dir public, please confirm if that's not the case.

It looks like the issue is that the public directory does not exist and you're trying to deploy it. Did you run npm run build first? I just tried cloning your repository, ran npm install && npm run build && npm run deploy, and it seemed to work.

[DavidWells]

The build folder is there locally. This is a regression in how the CLI works. Possibly related to how this site uses yarn workspaces? IDK

netlify deploy -p --dir public should deploy my site, instead it results in "Base directory does not exist: /xyz/site" Error with latest versions of CLI

Reverting to netlify-cli@2.40.0 the netlify deploy -p --dir public command works as expected & the site deploys

Additional context:

Error from running build command using yarn workspaces

Error from the site folder running npm run build command without yarn workspaces

Reverting to previous versions my deploys work as expected

[ehmicky]

I am having issues reproducing this problem. When I make sure npm run build has been run first, npm run deploy seems to work fine for me with the latest version of netlify-cli. @RaeesBhatti Do you manage to reproduce this issue?

[DavidWells]

Possibly related #862

[RaeesBhatti]

@DavidWells Can you try the following branch! see if you can still reproduce this issue there: #843

[timchambers]

I'm also hitting this now. Did not occur in 2.41.0, does occur in 2.42.0 and later. I'm also using yarn workspaces with this repository, in case that helps, since @DavidWells mentioned he is as well.

[zacaytion]

I'm having this issue too on version 2.47.0. I'm using yarn workspaces with two netlify projects and a wrapper bash script to handle the deploy logic.
I don't have the issue when I'm calling the cli directly from the shell, but when executing it via a bash script it appears to be interpreting the path wrong.
When calling the script from the /web directory in my workspace and passing the directory to deploy as /build the CLI is assuming I want to deploy the build located at /web/web/build rather than /web/build.

Reverting to version 2.40.0 resolved the issue