Added procedure and function grouping in metadata view. #78
Conversation
| import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.metadata.tree.MutableTreeNodeProducers; | ||
| import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.metadata.tree.Root; | ||
| import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.metadata.tree.TreeNodeDirectory; | ||
| import com.neueda.jetbrains.plugin.graphdb.jetbrains.ui.datasource.tree.*; |
There was a problem hiding this comment.
Please don't use imports with '*'. Use only imports what you need
| public Directory getDirectory(String name) { | ||
| return directories.computeIfAbsent( | ||
| name, | ||
| (k) -> new Directory(k, directoryProducer, functionProducer) |
There was a problem hiding this comment.
'k' stands for key, however I changed it to 'newName' for more understanding
|
|
||
| class Leaf implements TreeNode { | ||
| private final String name; | ||
| private Function<TreeNode, DefaultMutableTreeNode> mutableTreeNodeProducer; |
There was a problem hiding this comment.
mutableTreeNodeProducer should be final
| ); | ||
| } | ||
|
|
||
| private MutableTreeNodeProducers() { |
There was a problem hiding this comment.
Constructor should be in the top of the class
| public Directory getDirectory(String name) { | ||
| return directories.computeIfAbsent( | ||
| name, | ||
| (k) -> new Directory(k, directoryProducer, functionProducer) |
There was a problem hiding this comment.
I can't understand what is 'k'. Please use full names for the variables
There was a problem hiding this comment.
'k' stands for key, however I changed it to 'newName' for more understanding
|
|
||
| public interface TreeNode { | ||
|
|
||
| public String getName(); |
There was a problem hiding this comment.
Access modifier is 'public' is redudant here. In interfaces access modifier by default is public
|
|
||
| public String getName(); | ||
|
|
||
| public DefaultMutableTreeNode getMutableTreeNode(); |
There was a problem hiding this comment.
Access modifier is 'public' is redudant here. In interfaces access modifier by default is public
|
|
||
| public interface TreeNodeDirectory extends TreeNode { | ||
|
|
||
| public void addLeaf(String name); |
There was a problem hiding this comment.
Access modifier is 'public' is redudant here. In interfaces access modifier by default is public
|
|
||
| public void addLeaf(String name); | ||
|
|
||
| public TreeNodeDirectory getDirectory(String name); |
There was a problem hiding this comment.
Access modifier is 'public' is redudant here. In interfaces access modifier by default is public
- code style changed
sergejskovtuns
force-pushed
the
group-metadata-packages
branch
from
d5dacb2 to
3dd24e6
Compare
No description provided.