feat: emit pod events on drain #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthorsen
force-pushed
the
pod-events
branch
3 times, most recently
from
84f33ee to
5987b31
Compare
dthorsen
requested review from
a user,
danielpanzella,
dennisme,
mytunguyen and
nicoleyson
trutx
reviewed
May 17, 2021
trutx
reviewed
May 17, 2021
trutx
reviewed
May 17, 2021
|
If you plan to PR this upstream I'd suggest you add an extra test here https://github.com/newrelic-forks/aws-node-termination-handler/blob/main/test/e2e/spot-interruption-test-events-on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.