Apply Azure AD, B2C changes on next to fix provider semantics #1591

BenjaminWFox · 2021-03-26T02:02:49Z

What:

Created new provider azure-ad containing what was previously azure-ad-b2c
Updated content for provider azure-ad-b2c to reflect correct configuration for that provider

Why:

#1586

How:

Changes to Provider JS & MD files, and updating the provider index.

Checklist:

Documentation
Tests (May be N/A)
Ready to be merged
- Should be reviewed for correctness
- Do I need to do something specific to generate types?
- Doesn't pass deployment, unsure if that's expected at this point on next

* This will probably be a breaking change *

Anyone who previously has implemented what is currently provider azure-ad-b2c/Providers.AzureADB2C will need to update their provider to be azure-ad/Providers.AzureAD. There should be no other changes needed.

vercel · 2021-03-26T02:02:53Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/6ymYPZcyqTr698h19JC9WTEcZZVL
✅ Preview: https://next-auth-git-fork-benjaminwfox-bug-next-prov-1b4875-nextauthjs.vercel.app

balazsorban44 · 2021-03-26T11:52:17Z

Not sure why the Vercel deployment fails, I switched to your branch locally, and the build was successful. 🤷

Error log from Vercel

12:33:49.710 | ✔ Client: Compiled with some errors in 31.73s
12:33:49.713 | ./src/theme/SearchBar/algolia.css
12:33:49.713 | URIError: URI malformed
12:33:49.714 | at decodeURI ()
12:33:49.714 | @ ./src/theme/SearchBar/index.js 12:345-368
12:33:49.714 | @ ./node_modules/@docusaurus/theme-classic/lib-next/theme/Navbar/index.js
12:33:49.714 | @ ./node_modules/@docusaurus/theme-classic/lib-next/theme/Layout/index.js
12:33:49.714 | @ ./node_modules/@docusaurus/theme-classic/lib-next/theme/NotFound.js
12:33:49.714 | @ ./node_modules/@docusaurus/core/lib/client/exports/ComponentCreator.js
12:33:49.714 | @ ./.docusaurus/routes.js
12:33:49.714 | @ ./node_modules/@docusaurus/core/lib/client/clientEntry.js
12:33:49.714 | @ multi ./node_modules/@docusaurus/core/lib/client/clientEntry.js
12:33:49.715 | Client bundle compiled with errors therefore further build is impossible.
12:33:49.715 | ./src/theme/SearchBar/algolia.css
12:33:49.715 | Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
12:33:49.715 | ModuleBuildError: Module build failed (from ./node_modules/css-loader/dist/cjs.js):
12:33:49.715 | URIError: URI malformed
12:33:49.715 | at /vercel/workpath0/www/src/theme/SearchBar/algolia.css:522:3
12:33:49.715 | at decodeURI ()
12:33:49.715 | at normalizeUrl (/vercel/workpath0/www/node_modules/css-loader/dist/utils.js:114:10)
12:33:49.715 | at /vercel/workpath0/www/node_modules/css-loader/dist/plugins/postcss-url-parser.js:119:37
12:33:49.716 | at walk (/vercel/workpath0/www/node_modules/postcss-value-parser/lib/walk.js:7:16)
12:33:49.716 | at ValueParser.walk (/vercel/workpath0/www/node_modules/postcss-value-parser/lib/index.js:18:3)
12:33:49.717 | at parseDeclaration (/vercel/workpath0/www/node_modules/css-loader/dist/plugins/postcss-url-parser.js:97:10)
12:33:49.717 | at Declaration (/vercel/workpath0/www/node_modules/css-loader/dist/plugins/postcss-url-parser.js:248:29)
12:33:49.717 | at LazyResult.visitTick (/vercel/workpath0/www/node_modules/postcss/lib/lazy-result.js:456:16)
12:33:49.717 | at LazyResult.runAsync (/vercel/workpath0/www/node_modules/postcss/lib/lazy-result.js:372:30)
12:33:49.717 | at LazyResult.async (/vercel/workpath0/www/node_modules/postcss/lib/lazy-result.js:205:30)
12:33:49.717 | at LazyResult.then (/vercel/workpath0/www/node_modules/postcss/lib/lazy-result.js:190:17)
12:33:49.717 | at /vercel/workpath0/www/node_modules/webpack/lib/NormalModule.js:316:20
12:33:49.717 | at /vercel/workpath0/www/node_modules/loader-runner/lib/LoaderRunner.js:367:11
12:33:49.717 | at /vercel/workpath0/www/node_modules/loader-runner/lib/LoaderRunner.js:233:18
12:33:49.717 | at context.callback (/vercel/workpath0/www/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
12:33:49.717 | at Object.loader (/vercel/workpath0/www/node_modules/css-loader/dist/index.js:154:5)

UPDATE:
After I ran npm install in www, I got the same error as Vercel (It updated package-lock.json). I'll have to investigate this.

src/providers/index.js

BenjaminWFox · 2021-04-28T19:01:53Z

@balazsorban44 is this Types lint error a known issue? Unsure if I should do something in my code to fix that or if it will be fixed elsewhere on next.

Error: .../next-auth/types/adapters.d.ts:2:49
ERROR: 2:49  expect  [email protected] compile error:
Cannot find module 'typeorm' or its corresponding type declarations.

.../next-auth/types/index.d.ts:5:35
ERROR: 5:35  expect  [email protected] compile error:
Cannot find module 'typeorm' or its corresponding type declarations.

balazsorban44 · 2021-04-28T23:29:05Z

Yes, I guess it is "expected"... I am experimenting with cutting the typeorm package out of the core (making it optional to those who actually use it because takes up around 70% of the bundle...), but we still reference stuff in types from it. I'll have a look next time I am working on the next branch!

src/providers/azure-ad-b2c.js

src/providers/azure-ad.js

balazsorban44 · 2021-05-22T11:50:19Z

NOTE to other maintainers: When merging, we should to point out the breaking changes here, following the https://www.conventionalcommits.org/en/v1.0.0/ BREAKING CHANGE format for the commit message.

codecov-commenter · 2021-06-10T13:00:15Z

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 9.95%. Comparing base (0c17af9) to head (730ab57).

Files with missing lines	Patch %	Lines
src/providers/azure-ad-b2c.js	0.00%	8 Missing and 3 partials ⚠️
src/providers/azure-ad.js	0.00%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             next   #1591      +/-   ##
=========================================
- Coverage   10.05%   9.95%   -0.11%     
=========================================
  Files          81      82       +1     
  Lines        1382    1396      +14     
  Branches      387     390       +3     
=========================================
  Hits          139     139              
- Misses       1022    1033      +11     
- Partials      221     224       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

balazsorban44

Hi, @BenjaminWFox! Sorry for being slow on this, but I would like to pick this up now and get this merged! I had a simple comment, could you address that? If everything is fine, then I'll merge this ASAP, to get things ready for next-auth@4... 👀

www/docs/providers/azure-ad-b2c.md

BREAKING CHANGE: If you currently use `AzureADB2C`, you will need to update it to to `AzureAD` There should be no other changes needed.

Apply Azure AD, B2C changes on next

5337929

vercel bot had a problem deploying to Preview March 26, 2021 02:02 Failure

github-actions bot added core Refers to `@auth/core` docs Relates to documentation providers labels Mar 26, 2021

Fix lint errors

839018c

vercel bot had a problem deploying to Preview March 26, 2021 02:20 Failure

BenjaminWFox mentioned this pull request Mar 26, 2021

Provider "Azure Active Directory B2C" does not implement Azure AD B2C #1586

Closed

vercel bot had a problem deploying to Preview March 26, 2021 11:31 Failure

balazsorban44 added the help-needed The maintainer needs help due to time constraint/missing knowledge label Mar 26, 2021

vercel bot had a problem deploying to Preview March 26, 2021 15:32 Failure

vercel bot had a problem deploying to Preview March 30, 2021 16:18 Failure

Add additional note to AzureAD docs regarding tenant config options.

b0df359

vercel bot had a problem deploying to Preview March 30, 2021 22:46 Failure

BenjaminWFox mentioned this pull request Apr 2, 2021

v3 - CALLBACK_OAUTH_ERROR (Invalid state...) - Custom Provider Azure AD B2C #468

Closed

5 tasks

balazsorban44 mentioned this pull request Apr 23, 2021

feat(provider): add AzureAD provider #1822

Closed

3 tasks

Merge branch 'next' into bug/next-provider-azure-ad-b2c-naming-issue

8ea0205

vercel bot temporarily deployed to Preview April 28, 2021 18:33 Inactive

BenjaminWFox commented Apr 28, 2021

View reviewed changes

src/providers/index.js Outdated Show resolved Hide resolved

balazsorban44 requested changes Apr 28, 2021

View reviewed changes

src/providers/azure-ad-b2c.js Outdated Show resolved Hide resolved

src/providers/azure-ad.js Outdated Show resolved Hide resolved

src/providers/azure-ad.js Outdated Show resolved Hide resolved

Fix providers to be named default exports

37b1bfb

vercel bot temporarily deployed to Preview April 29, 2021 00:16 Inactive

Remove index.js

cc653ad

vercel bot temporarily deployed to Preview April 29, 2021 00:20 Inactive

Merge branch 'next' into bug/next-provider-azure-ad-b2c-naming-issue

cd2c95e

vercel bot temporarily deployed to Preview May 20, 2021 19:46 Inactive

balazsorban44 approved these changes May 22, 2021

View reviewed changes

This was referenced Jun 1, 2021

WIP: Prototype to add in next auth mcagov/beacons-webapp#285

Closed

Next auth (#286) mcagov/beacons-webapp#287

Merged

Use Azure B2C Provider for Next Auth once the PR has been merged mcagov/beacons-webapp#292

Closed

balazsorban44 added the breaking-change label Jun 10, 2021

Merge branch 'next' into bug/next-provider-azure-ad-b2c-naming-issue

1342645

vercel bot temporarily deployed to Preview June 10, 2021 12:58 Inactive

balazsorban44 requested changes Jun 10, 2021

View reviewed changes

www/docs/providers/azure-ad-b2c.md Outdated Show resolved Hide resolved

Add primary Azure AD B2C documentation link

730ab57

vercel bot temporarily deployed to Preview June 10, 2021 14:44 Inactive

balazsorban44 merged commit 5ac1db7 into nextauthjs:next Jun 10, 2021

BenjaminWFox mentioned this pull request Jun 12, 2021

The "key" argument must be of type string or an instance of ... or Buffer. Received undefined. #2170

Closed

balazsorban44 mentioned this pull request Jul 13, 2021

Azure AD B2C is using the wrong name #2362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Apply Azure AD, B2C changes on next to fix provider semantics #1591

Apply Azure AD, B2C changes on next to fix provider semantics #1591

Uh oh!

BenjaminWFox commented Mar 26, 2021 •

edited

Loading

Uh oh!

vercel bot commented Mar 26, 2021 •

edited

Loading

Uh oh!

balazsorban44 commented Mar 26, 2021 •

edited

Loading

Uh oh!

Uh oh!

BenjaminWFox commented Apr 28, 2021 •

edited

Loading

Uh oh!

balazsorban44 commented Apr 28, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

balazsorban44 commented May 22, 2021

Uh oh!

codecov-commenter commented Jun 10, 2021 •

edited by codecov bot

Loading

Uh oh!

balazsorban44 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Apply Azure AD, B2C changes on next to fix provider semantics #1591

Apply Azure AD, B2C changes on next to fix provider semantics #1591

Uh oh!

Conversation

BenjaminWFox commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

* This will probably be a breaking change *

Uh oh!

vercel bot commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balazsorban44 commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

BenjaminWFox commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

balazsorban44 commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

balazsorban44 commented May 22, 2021

Uh oh!

codecov-commenter commented Jun 10, 2021 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

balazsorban44 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BenjaminWFox commented Mar 26, 2021 •

edited

Loading

vercel bot commented Mar 26, 2021 •

edited

Loading

balazsorban44 commented Mar 26, 2021 •

edited

Loading

BenjaminWFox commented Apr 28, 2021 •

edited

Loading

balazsorban44 commented Apr 28, 2021 •

edited

Loading

codecov-commenter commented Jun 10, 2021 •

edited by codecov bot

Loading