Different folder for shared files

[Bungeefan]

Describe the feature you'd like to request

I have lots of "shared with me" files in my account, and currently they are all put in the top folder alongside my other private files from Google Drive.
I still want to import/backup them, but it would be nice if I could specify a separate folder for such files, so they don't necessarily clobber my "personal" drive export.

Describe the solution you'd like

An extra configurable field where I can optionally specify a different folder only for imported "shared with me" files.
Similar to the existing "target path" field from #39, but just for shared files/folders.

Describe alternatives you've considered

One could keep ignoring them during the import and download/upload them manually from Drive, alternatively move and merge them manually in NC after each import/sync.

[lukasdotcom]

Hi @Bungeefan

This feature request is currently not planned, but if you want to you can attempt to implement it yourself.

[Bungeefan]

Hi @lukasdotcom,

thanks for your response, I implemented my requested feature but also encountered some issues/had some findings while doing so:

• The ownedByMe check doesn't really align with the IMO user-expected "Shared with me" view on Google Drive.
  • For example, I have several files/folders that are owned by me, but reside in shared folders owned by somebody else. In Google Drive, those files appear only in my "Shared with me" view. But this integration currently puts them under the root folder during the import.
• The current ownedByMe check is done locally, even though the Google Drives API already provides an ownedByMe query option.
• Raw files (without folders) that are shared with you aren't imported at all via this integration.
  • As such files have no parents (not even root), they are never collected and therefore never found in the import loop.

Off-topic issues (but were a little bit annoying to discover while testing):

• Cancelling the import job only works if it hasn't started yet, after the initial start, there is no way to gracefully cancel it.
  • There is only one check at the beginning, and after that the importing_drive flag (which the cancel button toggles) is never checked again.
• Also, there is no log output whatsoever informing the user, if the job is intentionally delayed because the last execution didn't "yet" finish and is less than an hour ago.

I created fixes for all of them, and now wanted to ask you if you would like me to put them all in PRs, or only want the initially requested feature.

[lukasdotcom]

Hi @Bungeefan,

Thank you for working on this issue. If you already created fixes for all these other issues you can create a pr for each of them otherwise I can look a little closer eventually. I would recommend to keep the prs separate if that isn't too much work, but you can put them all in one if it is a lot of work.

[Bungeefan]

Hi @lukasdotcom,

I opened three PRs with the features/fixes mentioned:

• Add log informing user of intentional delay in job execution #284
• Add configurable "shared with me" output dir #285
• Allow cancelling already running job #286

Please feel free to request any changes you would like to see (I noted my concerns/questions in the respective descriptions)!