Skip to content

Conversation

@MarcelRobitaille
Copy link
Contributor

Fix #256

See also MarcelRobitaille#38

Copy link
Member

@lukasdotcom lukasdotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MarcelRobitaille

Thanks so much for the pr. You do still need to fix the failing psalm errors by editing the type definition on line 197 (You can see the exact error by running composer psalm), but other than that it did work wonderfully when I tested it myself.

@MarcelRobitaille
Copy link
Contributor Author

Hi @lukasdotcom Thanks for checking it. I'm working on making recurring event exceptions actually work properly. Should I include that in this PR, or finish it and open a new one?

Signed-off-by: Marcel Robitaille <[email protected]>
@lukasdotcom lukasdotcom self-requested a review September 15, 2025 12:20
Copy link
Member

@lukasdotcom lukasdotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukasdotcom Thanks for checking it. I'm working on making recurring event exceptions actually work properly. Should I include that in this PR, or finish it and open a new one?

You can open a new one for that. This pr can be merged, thanks. 🚀

@lukasdotcom lukasdotcom merged commit 5bda161 into nextcloud:main Sep 15, 2025
20 checks passed
@Moudilu
Copy link

Moudilu commented Sep 15, 2025

Thanks for fixing this @MarcelRobitaille !

@MarcelRobitaille MarcelRobitaille deleted the fix_256 branch September 15, 2025 13:18
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timezone not migrated

3 participants