Skip to content

Fix net::ERR_CONTENT_LENGTH_MISMATCH #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2021
Merged

Fix net::ERR_CONTENT_LENGTH_MISMATCH #45

merged 2 commits into from
Jan 30, 2021

Conversation

Moumouls
Copy link
Contributor

@Moumouls Moumouls commented Jan 30, 2021 •
edited
Loading

Closes #20

  • Failing test
  • Implementation

@Moumouls Moumouls mentioned this pull request Jan 30, 2021
Closed
@Moumouls Moumouls changed the title Fix huge data error Fix net::ERR_CONTENT_LENGTH_MISMATCH Jan 30, 2021
@ngfelixl ngfelixl self-requested a review January 30, 2021 13:03
@ngfelixl
Copy link
Owner

Hi @Moumouls, this has been an open issue for a long time, thank you a lot for submitting a fix. You've named your commit wip. Is it still work in progress? Otherwise could you please rename the commit message to the following?

fix: content length mismatch

Closes #20

Just in case: git commit --amend, edit+save+close, force push. If it is not in wip, I start reviewing. Did the formatting happen due to auto-format?

@Moumouls
Copy link
Contributor Author

Moumouls commented Jan 30, 2021 •
edited
Loading

It's not a wip, sorry for the commit naming, because during the fast patch, I switched from my branch to master to check that the new test correctly fail on master, I sent a wrong commit message :)

@Moumouls
Copy link
Contributor Author

Moumouls commented Jan 30, 2021 •
edited
Loading

And yes i always forget that i have prettier activated by default...

@ngfelixl if you want i can add a simple prettier config

@Moumouls Moumouls force-pushed the moumouls/fix-huge-data branch from d534493 to e956cb0 Compare January 30, 2021 13:48
@ngfelixl ngfelixl merged commit 16eec29 into ngfelixl:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngfelixl ngfelixl ngfelixl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting error Failed to load resource: net::ERR_CONTENT_LENGTH_MISMATCH
2 participants
@Moumouls @ngfelixl