Skip to content

Fix test_dos_sec_logs_on #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Fix test_dos_sec_logs_on #5725

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7b08e1
Fix test_dos_sec_logs_on
pasmant Jun 11, 2024
51755ea
Merge branch 'main' into fix_dos_tests
vepatel Jun 11, 2024
793968b
Merge branch 'main' into fix_dos_tests
AlexFenlon Jun 11, 2024
bc99619
Merge branch 'main' into fix_dos_tests
vepatel Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/suite/test_dos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ def test_ap_nginx_config_entries(
for _ in conf_nginx_directive:
assert _ in nginx_config

@pytest.mark.skip(reason="Intermittent failures while sending dos logs to syslog")
def test_dos_sec_logs_on(
self,
kube_apis,
Expand Down Expand Up @@ -239,6 +238,7 @@ def test_dos_sec_logs_on(
get_ingress_nginx_template_conf(kube_apis.v1, test_namespace, "dos-ingress", pod_name, "nginx-ingress")

print("----------------------- Send request ----------------------")
wait_before_test(5)
response = requests.get(dos_setup.req_url, headers={"host": "dos.example.com"}, verify=False)
print(response.text)
wait_before_test(10)
Expand All @@ -250,7 +250,7 @@ def test_dos_sec_logs_on(

print(log_contents)
retry = 0
while 'product="app-protect-dos"' not in log_contents and retry < 10:
while 'product="app-protect-dos"' not in log_contents and retry < 20:
wait_before_test()
retry += 1

Expand Down