Add OIDC timeout customization to ConfigMap #8495

AlexFenlon · 2025-11-05T13:44:15Z

Proposed changes

Add an options for users to change timeout values for OIDC
Fix a bug when PKCE was enabled for two or more virtual servers resulting in a duplicate keyval_zone log. The fix was to separate the pkce_supplements.conf intho the respective templates which was required for this change regardless.

Warning  AddedOrUpdatedWithError    20s   nginx-ingress-controller  Configuration for default/webapp was added or updated ; but was not applied: error when reloading NGINX when updating Policy: nginx reload failed: command /usr/sbin/nginx -s reload -e stderr stdout: ""
stderr: "2025/11/04 14:02:41 [emerg] 44#44: duplicate zone \"oidc_pkce\" in /etc/nginx/oidc/oidc_pkce_supplements.conf:5\n"

eg.
ConfigMap

...
data:
  zone-sync: "true"
  resolver-addresses: kube-dns.kube-system.svc.cluster.local
  resolver-valid: 5s
  oidc-pkce-timeout: 2m
  oidc-id-tokens-timeout: 2h
  oidc-access-tokens-timeout: 30m
  oidc-refresh-tokens-timeout: 1h
  oidc-sids-timeout: 120s

nginx.conf

    keyval_zone zone=oidc_pkce:128K        timeout=2m sync;
    keyval_zone zone=oidc_id_tokens:1M     timeout=2h sync;
    keyval_zone zone=oidc_access_tokens:1M timeout=30m sync;
    keyval_zone zone=refresh_tokens:1M     timeout=1h sync;
    keyval_zone zone=oidc_sids:1M          timeout=120s sync;
    include oidc/oidc_common.conf;

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

…-timeout

codecov · 2025-11-05T13:50:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.58%. Comparing base (b90ad21) to head (1a29b69).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8495      +/-   ##
==========================================
+ Coverage   53.41%   53.58%   +0.17%     
==========================================
  Files          91       91              
  Lines       18191    18250      +59     
==========================================
+ Hits         9717     9780      +63     
+ Misses       7962     7960       -2     
+ Partials      512      510       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-11-05T14:05:54Z

Package Report

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx, 1.29.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 3.3.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx, 1.29.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-module-njs, 1.29.1+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-module-otel, 1.29.1+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 3.3.2~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 3.3.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus, 35-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-njs, 35+0.9.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-otel, 35+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-fips-check, 35+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 3.3.2~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-appprotect, 35+5.527.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect, 35+5.527.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-attack-signatures, 2025.10.29-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-threat-campaigns, 2025.11.03-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 2.44.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-appprotect, 35+5.527.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-module-plus, 35+5.527.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-plugin, 6.23.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 2.44.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus, 35-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-njs, 35+0.9.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-otel, 35+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-fips-check, 35+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-appprotect, 35+5.527.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect, 35+5.527.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-attack-signatures, 2025.10.29-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-threat-campaigns, 2025.11.03-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-plus-module-appprotectdos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, app-protect-dos, 35+4.7.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590, nginx-agent, 2.44.0~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx, 1.29.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-agent, 3.3.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx, 1.29.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-module-njs, 1.29.1.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-module-otel, 1.29.1.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-agent, 3.3.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-agent, 3.3.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine, nginx-agent, 3.3.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-agent, 3.3.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus, 35-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-agent, 3.3.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-agent, 2.44.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-appprotect, 35.5.527.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, app-protect, 35.5.527.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, app-protect-attack-signatures, 2025.10.29-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, app-protect-threat-campaigns, 2025.11.03-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus, 35-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-njs, 35.0.9.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-otel, 35.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-fips-check, 35.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-agent, 2.44.0, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, nginx-plus-module-appprotect, 35.5.527.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, app-protect-module-plus, 35.5.527.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-alpine-fips, app-protect-plugin, 6.23.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx, 1.29.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-module-njs, 1.29.1+0.9.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 3.3.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx, 1.29.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-module-njs, 1.29.1+0.9.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-module-otel, 1.29.1+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 3.3.2-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 3.3.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus, 35-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 3.3.2-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 2.44.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-appprotect, 35+5.527.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect, 35+5.527.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-attack-signatures, 2025.10.29-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-threat-campaigns, 2025.11.03-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 2.44.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-appprotect, 35+5.527.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-module-plus, 35+5.527.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-plugin, 6.23.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-agent, 2.44.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-appprotect, 35+5.527.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, app-protect, 35+5.527.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, app-protect-attack-signatures, 2025.10.29-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, app-protect-threat-campaigns, 2025.11.03-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus, 35-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-njs, 35+0.9.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-otel, 35+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-fips-check, 35+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-agent, 2.44.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, nginx-plus-module-appprotect, 35+5.527.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, app-protect-module-plus, 35+5.527.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi8, app-protect-plugin, 6.23.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus, 35-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-njs, 35+0.9.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-otel, 35+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-fips-check, 35+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-appprotect, 35+5.527.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-plus-module-appprotectdos, 35+4.7.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, nginx-agent, 2.44.0-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect, 35+5.527.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-attack-signatures, 2025.10.29-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-threat-campaigns, 2025.11.03-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-f1dc63f935f8d6a8a85c376e08fbb590-ubi, app-protect-dos, 35+4.7.3-1.el9.ngx, x86_64

AlexFenlon · 2025-11-05T15:49:21Z

Based on the discussion internally, we have decided to leave the sync flag hardcoded in the keyval_zone configuration.

While this change makes sense on the surface, changing the sync flag based on if the zone-sync flag is enabled, doing so could introduce breaking changes for users relying on the old method (snippets) as well as cause inconsistancies with upgrading.

Previous examples, such as rate-limiting, there was a workaround we did which was appending _sync to the zone name when zone-sync was enabled though the ConfigMap. This is a good approach but for this it doesn't seem the right approch for this case for backwards compatability reasons.

Copilot

Pull Request Overview

This PR adds customizable timeout configuration for OIDC authentication parameters and fixes a duplicate zone definition bug that occurred when PKCE was enabled for multiple virtual servers.

Adds five new ConfigMap parameters for OIDC timeout customization (PKCE, ID tokens, access tokens, refresh tokens, and SIDs)
Moves keyval_zone definitions from static configuration files into the main template with configurable timeout values
Replaces the include oidc/oidc_pkce_supplements.conf directive with inline keyval declarations to prevent duplicate zone errors

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
internal/configs/version2/templates_test.go	Updates test expectation to match new inline keyval directive
internal/configs/version2/nginx-plus.virtualserver.tmpl	Replaces PKCE supplements include with inline keyval declaration
internal/configs/version2/snapshots/templates_test.snap	Updates test snapshots to reflect template changes
internal/configs/version1/nginx-plus.tmpl	Adds configurable keyval_zone definitions with timeout parameters
internal/configs/version1/config.go	Introduces OIDCConfig struct to replace boolean OIDC flag
internal/configs/oidc/oidc_pkce_supplements.conf	Removes file that caused duplicate zone definitions
internal/configs/oidc/oidc_common.conf	Removes hardcoded keyval_zone definitions (moved to template)
internal/configs/configmaps_test.go	Adds comprehensive test coverage for OIDC timeout parsing
internal/configs/configmaps.go	Implements parsing logic for OIDC timeout ConfigMap parameters
internal/configs/config_params.go	Adds OIDC struct to ConfigParams with default timeout values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/configs/configmaps.go

pdabelf5

Can we get some tests that show the values outside the defaults

…test that checks OIDC timeout nginx conf values

…nto enhancement/oidc-pkce-timeout

AlexFenlon added 3 commits November 4, 2025 14:47

Fix pkce bug duplicate keyval_zone for multiple VS

862fca5

Add OIDC timeout customization to ConfigMap

c18f691

Merge remote-tracking branch 'origin/main' into enhancement/oidc-pkce…

de07016

…-timeout

github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code labels Nov 5, 2025

AlexFenlon linked an issue Nov 5, 2025 that may be closed by this pull request

OIDC pkce timeout #8213

Closed

AlexFenlon self-assigned this Nov 5, 2025

Merge branch 'main' into enhancement/oidc-pkce-timeout

3ff11d7

AlexFenlon added 2 commits November 5, 2025 15:26

revert sync back to original

82dae94

Merge branch 'main' into enhancement/oidc-pkce-timeout

25450c1

AlexFenlon marked this pull request as ready for review November 5, 2025 16:02

AlexFenlon requested a review from a team as a code owner November 5, 2025 16:02

Copilot AI review requested due to automatic review settings November 5, 2025 16:02

Copilot AI reviewed Nov 5, 2025

View reviewed changes

AlexFenlon added 2 commits November 5, 2025 16:20

update error messages

21a83fa

Merge branch 'main' into enhancement/oidc-pkce-timeout

8da33ae

javorszky previously approved these changes Nov 5, 2025

View reviewed changes

pdabelf5 requested changes Nov 5, 2025

View reviewed changes

Update OIDC timeout test, add errors timeout test, add VirtualServer …

61190da

…test that checks OIDC timeout nginx conf values

AlexFenlon dismissed javorszky’s stale review via 61190da November 6, 2025 14:05

AlexFenlon added 5 commits November 6, 2025 14:07

Merge branch 'main' into enhancement/oidc-pkce-timeout

16142dc

Add OIDC timeout template tests, remove unneeded test

c2fd3b6

Merge remote-tracking branch 'origin/enhancement/oidc-pkce-timeout' i…

87306f5

…nto enhancement/oidc-pkce-timeout

Merge branch 'main' into enhancement/oidc-pkce-timeout

f57e799

fix snaps

4ad72bf

pdabelf5 approved these changes Nov 6, 2025

View reviewed changes

Merge branch 'main' into enhancement/oidc-pkce-timeout

1a29b69

vepatel approved these changes Nov 6, 2025

View reviewed changes

AlexFenlon merged commit 6725ed6 into main Nov 6, 2025
94 checks passed

AlexFenlon deleted the enhancement/oidc-pkce-timeout branch November 6, 2025 16:55

This was referenced Nov 6, 2025

Add OIDC Timeout config options to NIC ConfigMap nginx/documentation#1410

Closed

feat: add OIDC timeout config options to NIC ConfigMap nginx/documentation#1413

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add OIDC timeout customization to ConfigMap #8495

Add OIDC timeout customization to ConfigMap #8495

Uh oh!

AlexFenlon commented Nov 5, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

AlexFenlon commented Nov 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pdabelf5 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add OIDC timeout customization to ConfigMap #8495

Add OIDC timeout customization to ConfigMap #8495

Uh oh!

Conversation

AlexFenlon commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Report

Uh oh!

AlexFenlon commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pdabelf5 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AlexFenlon commented Nov 5, 2025 •

edited

Loading

codecov bot commented Nov 5, 2025 •

edited

Loading

github-actions bot commented Nov 5, 2025 •

edited

Loading

AlexFenlon commented Nov 5, 2025 •

edited

Loading