Perform theme switch before first paint #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nginx-jack
requested review from
JTorreG,
travisamartin,
ADubhlaoich and
LukeBillington
as code owners
nginx-jack
force-pushed
the
refactor-theme-switcher
branch
from
0b27ca0 to
cef6325
Compare
danielledeleo
requested changes
Jan 27, 2025
nginx-jack
force-pushed
the
refactor-theme-switcher
branch
from
cef6325 to
864c31f
Compare
danielledeleo
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform theme switch before first paint.
This stops the theme "flashing" every time you change page.
Test with
useNewTheme(true)anduseNewTheme(false)