Skip to content

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Jan 29, 2025

Proposed changes

  • Changing font weight on sidebar to be thinner.
  • Refactored sidebar lines to be centered.
  • Converted from rem to px.
  • Changed the JS for the site dropdown to remove border at the bottom when dropdown is active.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about the change from relative units to fixed units, but I trust it's for good reason.

@nginx-jack nginx-jack requested a review from a team January 29, 2025 17:22
@lamATnginx lamATnginx merged commit 04edd69 into main Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants