Skip to content

Add lighthouse to build workflow #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 23, 2025
Merged

Add lighthouse to build workflow #402

merged 28 commits into from
Sep 23, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Sep 17, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner September 17, 2025 18:54
@lamATnginx lamATnginx added the enhancement New feature or request label Sep 17, 2025
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/402/

@lamATnginx
Copy link
Collaborator Author

Pipeline is failing on purpose as we wait for the secrets to be added to the repo.

@lamATnginx lamATnginx marked this pull request as draft September 17, 2025 19:18
@lamATnginx lamATnginx force-pushed the add-lighthouse branch 8 times, most recently from 528f6b1 to d550f35 Compare September 22, 2025 19:24
nginx-jack
nginx-jack reviewed Sep 23, 2025
View reviewed changes
@lamATnginx lamATnginx marked this pull request as ready for review September 23, 2025 15:26
@lamATnginx
Copy link
Collaborator Author

Workflow failing on purpose since we don't have a lighthouse-report-main in the artifact store.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@lamATnginx lamATnginx force-pushed the add-lighthouse branch 2 times, most recently from 43ab5f4 to addb091 Compare September 23, 2025 18:04
@lamATnginx lamATnginx force-pushed the add-lighthouse branch 2 times, most recently from 9621a7f to 4945933 Compare September 23, 2025 20:21
TasoOneAsia
TasoOneAsia approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments

@lamATnginx lamATnginx merged commit 423bcd8 into main Sep 23, 2025
7 checks passed
@lamATnginx lamATnginx deleted the add-lighthouse branch September 23, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nginx-jack nginx-jack nginx-jack left review comments

@TasoOneAsia TasoOneAsia TasoOneAsia approved these changes

Assignees

@lamATnginx lamATnginx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamATnginx @TasoOneAsia @nginx-jack