Install and configure Vale with Google Developer style guide rules #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sg-writer
added
kind/enhancement
sg-writer
force-pushed
the
sg/doc-428-set-up-vale-in-mintlify
branch
from
fa03f37 to
db76b41
Compare
sg-writer
force-pushed
the
sg/doc-428-set-up-vale-in-mintlify
branch
from
d551ff6 to
44923be
Compare
S3Prototype
reviewed
Oct 3, 2025
S3Prototype
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
I updated the readme and dependencies, since I was having some issues. Unfortunately it looks like we're going to just have to tell people to install vale separately, rather than have it bundled in with our project dependencies so they can just pnpm i.
Anyway, I think for now we should make it so vale doesn't block any PRs from merging until we do a separate PR to fix all the existing errors
|
ah weird, didn't realize Vale had to be installed on your device in addition to the project itself. Thanks for addressing that. I tried to get an LLM to address the errors and it failed miserably 🫠 so I'll try tackling that by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR installs Vale with (most of) the Google style rules package to get us started. I made some changes throughout to make it more useful to us but there's definitely more to be done. This should be enough to start using Vale right away as a CI check.
I tried getting an LLM to fix the 500ish errors reported but it made a colossal mess so I had to revert all of those changes. We can start to actually apply the Vale rules in follow-up PRs.
The command to run it is
pnpm run vale. There are lots of flags available to refine it.Note: once this PR is merged we'll need to turn Vale back on in the Mintlify dashboard to get the CI checks.