Skip to content

Fix BeforeAssemble call for Map and IdentifierBag #3380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix BeforeAssemble call for Map and IdentifierBag #3380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75d7f4f
Fix BeforeAssemble call for Map and IdentifierBag
bahusoid Jul 24, 2023
95dc9e4
Generate async files
github-actions[bot] Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NHibernate/Async/Collection/Generic/PersistentGenericIdentifierBag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public override async Task InitializeFromCacheAsync(ICollectionPersister persist

var identifierType = persister.IdentifierType;
var elementType = persister.ElementType;
for (int i = 0; i < size; i++)
for (int i = 0; i < size; i += 2)
{
await (identifierType.BeforeAssembleAsync(array[i], Session, cancellationToken)).ConfigureAwait(false);
await (elementType.BeforeAssembleAsync(array[i + 1], Session, cancellationToken)).ConfigureAwait(false);
Expand Down
4 changes: 2 additions & 2 deletions src/NHibernate/Async/Collection/Generic/PersistentGenericMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ public override async Task InitializeFromCacheAsync(ICollectionPersister persist
object[] array = (object[])disassembled;
int size = array.Length;
BeforeInitialize(persister, size);

var indexType = persister.IndexType;
var elementType = persister.ElementType;
for (int i = 0; i < size; i++)
for (int i = 0; i < size; i += 2)
{
await (indexType.BeforeAssembleAsync(array[i], Session, cancellationToken)).ConfigureAwait(false);
await (elementType.BeforeAssembleAsync(array[i + 1], Session, cancellationToken)).ConfigureAwait(false);
Expand Down
2 changes: 1 addition & 1 deletion src/NHibernate/Collection/Generic/PersistentGenericIdentifierBag.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public override void InitializeFromCache(ICollectionPersister persister, object

var identifierType = persister.IdentifierType;
var elementType = persister.ElementType;
for (int i = 0; i < size; i++)
for (int i = 0; i < size; i += 2)
{
identifierType.BeforeAssemble(array[i], Session);
elementType.BeforeAssemble(array[i + 1], Session);
Expand Down
4 changes: 2 additions & 2 deletions src/NHibernate/Collection/Generic/PersistentGenericMap.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ public override void InitializeFromCache(ICollectionPersister persister, object
object[] array = (object[])disassembled;
int size = array.Length;
BeforeInitialize(persister, size);

var indexType = persister.IndexType;
var elementType = persister.ElementType;
for (int i = 0; i < size; i++)
for (int i = 0; i < size; i += 2)
{
indexType.BeforeAssemble(array[i], Session);
elementType.BeforeAssemble(array[i + 1], Session);
Expand Down