Try to fix CI failures #15701
Merged
Try to fix CI failures #15701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
since it doesn't work for binary only packages, and always install head
| result.options = options | ||
| result.startTime = epochTime() | ||
|
|
||
| proc actionRetry(maxRetry: int, backoffDuration: float, action: proc: bool): bool = |
Member
There was a problem hiding this comment.
@Clyybber why did you remove this? this was there for a good reason, reducing spurious git clone failures which used to happen a lot before this was added
Member
There was a problem hiding this comment.
ping @Clyybber , I'm now getting 503/443 errors again after your removal of actionRetry which was introduced for this very purpose in #14547
eg: in https://github.com/nim-lang/Nim/pull/15765/checks?check_run_id=1323632253 i just got:
Installing recaptcha@>= 1.0.3
Downloading euantorano/recaptcha.nim using git
download.nim(93) getTagsListRemote
Error: unhandled exception: Unable to query remote tags for euantorano/recaptcha.nim. Git returned: fatal: unable to access 'euantorano/recaptcha.nim': Failed to connect to github.com port 443: Connection refused
[OSError]
Member
There was a problem hiding this comment.
ping @Clyybber this type of failure keeps happening and was mostly solved with actionRetry
Contributor
Author
There was a problem hiding this comment.
Sorry, this slipped my notifications. PR incoming EDIT: #16262
narimiran
pushed a commit
that referenced
this pull request
Oct 27, 2020
* Use cligens release version * Rework important_packages main loop * Fix * Fix * Create pkgs dir * Don't use nimble develop since it doesn't work for binary only packages, and always install head * Use git to get the latest release/tag instead * Tackle the root cause * Reduce diff * Cleanup (cherry picked from commit e18fc69)
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
* Use cligens release version * Rework important_packages main loop * Fix * Fix * Create pkgs dir * Don't use nimble develop since it doesn't work for binary only packages, and always install head * Use git to get the latest release/tag instead * Tackle the root cause * Reduce diff * Cleanup
irdassis
pushed a commit
to irdassis/Nim
that referenced
this pull request
Mar 16, 2021
* Use cligens release version * Rework important_packages main loop * Fix * Fix * Create pkgs dir * Don't use nimble develop since it doesn't work for binary only packages, and always install head * Use git to get the latest release/tag instead * Tackle the root cause * Reduce diff * Cleanup
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
* Use cligens release version * Rework important_packages main loop * Fix * Fix * Create pkgs dir * Don't use nimble develop since it doesn't work for binary only packages, and always install head * Use git to get the latest release/tag instead * Tackle the root cause * Reduce diff * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.