-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
doAssertRaises improvements; nimscript supports except Exception as e
#15765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except Exception as e
Araq
reviewed
Nov 2, 2020
1af1b70 to
f8b7583
Compare
Member
Author
|
@Araq PTAL, see #15765 (comment) |
ringabout
reviewed
Nov 9, 2020
f8b7583 to
62a481e
Compare
…ich exception is raised on mismatch
62a481e to
d15a7d3
Compare
Member
Author
|
PTAL, removed overload from this PR |
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Jan 6, 2021
…e` (nim-lang#15765) * doAssertRaises now correctly handles foreign exceptions; now shows which exception is raised on mismatch * nimscript now handles `Exception as e` * remove catch-all doAssertRaises overload from this PR Co-authored-by: Andreas Rumpf <[email protected]>
mildred
pushed a commit
to mildred/Nim
that referenced
this pull request
Jan 11, 2021
…e` (nim-lang#15765) * doAssertRaises now correctly handles foreign exceptions; now shows which exception is raised on mismatch * nimscript now handles `Exception as e` * remove catch-all doAssertRaises overload from this PR Co-authored-by: Andreas Rumpf <[email protected]>
irdassis
pushed a commit
to irdassis/Nim
that referenced
this pull request
Mar 16, 2021
…e` (nim-lang#15765) * doAssertRaises now correctly handles foreign exceptions; now shows which exception is raised on mismatch * nimscript now handles `Exception as e` * remove catch-all doAssertRaises overload from this PR Co-authored-by: Andreas Rumpf <[email protected]>
ardek66
pushed a commit
to ardek66/Nim
that referenced
this pull request
Mar 26, 2021
…e` (nim-lang#15765) * doAssertRaises now correctly handles foreign exceptions; now shows which exception is raised on mismatch * nimscript now handles `Exception as e` * remove catch-all doAssertRaises overload from this PR Co-authored-by: Andreas Rumpf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
except Exception as e{.emit:""" #include <stdexcept> void fn(){ throw std::runtime_error("asdf"); } """.} proc fn(){.importcpp.} proc main() = # ok doAssertRaises(void): fn() # ok doAssertRaises(AssertionDefect): doAssert false doAssertRaises(Exception): raise newException(Exception, "") doAssertRaises(Exception): doAssert false # these will raise AssertionDefect when false: doAssertRaises(Exception): fn() # expected raising 'Exception', instead raised foreign exception by: doAssertRaises(CatchableError): fn() # expected raising 'CatchableError', instead raised foreign exception by: doAssertRaises(CatchableError): doAssert false # expected raising 'CatchableError', instead raised 'AssertionDefect' by: doAssertRaises(void): doAssert false # expected raising 'foreign exception', instead raised 'AssertionDefect' by: main()