promote math.isNaN #16627
Closed
promote math.isNaN #16627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheecour
reviewed
Jan 7, 2021
timotheecour
approved these changes
Jan 7, 2021
Member
timotheecour
left a comment
timotheecour
left a comment
There was a problem hiding this comment.
LGTM after addressing comment
timotheecour
reviewed
Jan 8, 2021
Member
|
CI failure was caused by #16646, I commited a workaround patch |
timotheecour
approved these changes
Jan 9, 2021
Member
|
Sorry, but the older version is less code and this is not performance critical at all. |
Member
|
postponed till #16646 is fixed then, by which point there wouldn't need to have the missing |
timotheecour
added a commit
to timotheecour/Nim
that referenced
this pull request
Apr 29, 2021
2 tasks
Araq
pushed a commit
that referenced
this pull request
Apr 30, 2021
…17895) * revive #16627 now that csources_v1 was merged * use dedent in rst.nim, refs #17257 (comment) * fix test and improve rendering of a rst warning
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
…ces_v1 (nim-lang#17895) * revive nim-lang#16627 now that csources_v1 was merged * use dedent in rst.nim, refs nim-lang#17257 (comment) * fix test and improve rendering of a rst warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isNaNis more efficient thanclassify(x) == fcNan.Ref timotheecour#64 (comment)