fix #18142: nim doc now works across windows partitions (and make nativeToUnixPath work with abs paths)
#18501
Conversation
timotheecour
added
the
Ready For Review
| # permissions), it'll abort iteration and there would be no way to | ||
| # continue iteration. | ||
|
|
||
| proc nativeToUnixPath*(path: string): string = |
There was a problem hiding this comment.
As I (and others) have mentioned elsewhere, this is not a function that should be used. It cannot accurately translate paths without either a loss of information, or ambiguity. Windows has a couple of different path types and using a function that attempts to convert them all to some standard format is not going to work. Please stop pushing this.
There was a problem hiding this comment.
It cannot accurately translate paths without either a loss of information, or ambiguity.
cygwin works just fine, which is almost what I'm doing. future work will follow more closely what cygpath does, so that a spec is followed, you can't argue with that (I'm currently almost doing the same except for 2 edge cases).
|
The Nim doc generator should avoid nativeToUnixPath and get fixed differently. |
|
Sorry, I didn't realize this is an internal API. |
timotheecour
added
the
TODO: followup needed
3 participants
fix #18142 (and this was also needed in another PR)
follows cygwin convention which is the most reasonable way to convert C:\foo to a unix path