Fix some styleCheck bugs
#20095
Merged
Fix some styleCheck bugs
#20095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantimnot
changed the title
styleCheck bugs [skip ci]styleCheck bugs
quantimnot
force-pushed
the
pr_stylecheck_bugs
branch
from
f7cfcfe to
149ce83
Compare
quantimnot
force-pushed
the
pr_stylecheck_bugs
branch
from
149ce83 to
166ea56
Compare
Araq
reviewed
Sep 2, 2022
quantimnot
force-pushed
the
pr_stylecheck_bugs
branch
from
166ea56 to
5e398fe
Compare
|
@Araq Is this ok to merge? |
|
@Varriount No. |
refs nim-lang#19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised.
quantimnot
force-pushed
the
pr_stylecheck_bugs
branch
from
c461670 to
a9862b4
Compare
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
May 15, 2023
refs nim-lang#19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised. Co-authored-by: quantimnot <[email protected]>
capocasa
pushed a commit
to capocasa/Nim
that referenced
this pull request
May 16, 2023
refs nim-lang#19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised. Co-authored-by: quantimnot <[email protected]>
narimiran
pushed a commit
that referenced
this pull request
Jun 15, 2023
refs #19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised. Co-authored-by: quantimnot <[email protected]> (cherry picked from commit 365a753)
narimiran
pushed a commit
that referenced
this pull request
Jun 15, 2023
refs #19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised. Co-authored-by: quantimnot <[email protected]> (cherry picked from commit 365a753)
narimiran
pushed a commit
that referenced
this pull request
Jun 15, 2023
refs #19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised. Co-authored-by: quantimnot <[email protected]> (cherry picked from commit 365a753)
bung87
pushed a commit
to bung87/Nim
that referenced
this pull request
Jul 29, 2023
refs nim-lang#19822 Fixes these bugs: * Style check violations in generics defined in foreign packages are raised. * Builtin pragma usage style check violations in foreign packages are raised. * User pragma definition style check violations are not raised. Co-authored-by: quantimnot <[email protected]>
This was referenced Oct 10, 2024
Araq
pushed a commit
that referenced
this pull request
Oct 11, 2024
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99
narimiran
pushed a commit
that referenced
this pull request
Oct 11, 2024
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99 (cherry picked from commit aaf6c40)
narimiran
pushed a commit
that referenced
this pull request
Jan 14, 2025
fixes #24269, refs #20095 Instead of checking the package of the *used sym* to determine whether a stylecheck should trigger, we check the package of the lineinfo instead. Before #20095 this checked for the current compilation context module instead which caused issues with generic procs, but the lineinfo should more closely match the AST. I figured this might cause issues with includes etc but the foreign package test specifically tests for an include and passes, so maybe the package determining logic accounts for this already. This still might not be the correct logic, I'm not too familiar with the package handling in the compiler. Package PRs, both merged: - json_rpc: status-im/nim-json-rpc#226 - json_serialization: status-im/nim-json-serialization#99 (cherry picked from commit aaf6c40)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #19822
Fixes these bugs (look at the added tests for details):
Inconsistent usage style of foreign symbols within a module are not raised. #19822#issuecomment-1227125459(This is still an issue, but my approach isn't accepted, so it needs addressed later.)