Skip to content

fixes #20397; fixes stylecheck regression #20398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2022
Merged

fixes #20397; fixes stylecheck regression #20398

merged 6 commits into from
Sep 21, 2022

Conversation

@ringabout
Copy link
Member

@ringabout ringabout commented Sep 20, 2022 •
edited
Loading

fixes #20397

@ringabout
Copy link
Member Author

ringabout commented Sep 20, 2022 •
edited
Loading

The CI seems to have some connection issues.

@ringabout ringabout marked this pull request as ready for review September 21, 2022 09:51
@ringabout ringabout changed the title fixes #20397; fixes stylecheck fixes #20397; fixes stylecheck regression Sep 21, 2022
@Varriount Varriount merged commit 70c25c4 into devel Sep 21, 2022
@Varriount Varriount deleted the pr_stylecheck branch September 21, 2022 19:04
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 70c25c4

Hint: mm: orc; threads: on; opt: speed; options: -d:release
164263 lines; 15.264s; 842.324MiB peakmem

@metagn
Copy link
Collaborator

metagn commented Sep 28, 2022

It seems #19822 was backported but this was not. Does this mean 1.6.8 has #20397?

@ringabout
Copy link
Member Author

ringabout commented Sep 28, 2022 •
edited
Loading

My bad, I reported the issue yesterday. Hopefully there would be a hotfix.

@ringabout
Copy link
Member Author

ringabout commented Sep 28, 2022 •
edited
Loading

@narimiran could you please make a hotfix?

While we're at it, fd76c00 is too risky for 1.6.8 and it is not actually needed. Changing belongsToStdlib to partOfStdlib should make the CI green.

@narimiran
Copy link
Member

could you please make a hotfix?

What exactly would that be? 1.6.10 or some "new 1.6.8"?

(Why is nobody paying attention to the release candidates? :'( 1.6.8RC was available for more than two weeks and there wasn't a single remark....)

@metagn
Copy link
Collaborator

metagn commented Sep 28, 2022

I would say 1.6.10, but only after a couple of days in case more issues are found.

I would suggest making blog posts for the release candidates or posting on Reddit/Discord/more places. It gets buried easily on the forum.

narimiran pushed a commit that referenced this pull request Sep 30, 2022
@ringabout @narimiran
fixes #20397; fixes stylecheck regression (#20398)
31fe32a 
* fixes  #20397; fixes stylecheck

* add testcase

(cherry picked from commit 70c25c4)
@narimiran
Copy link
Member

This is now backported, and it will be part of 1.6.10.

While we're at it, fd76c00 is too risky for 1.6.8 and it is not actually needed. Changing belongsToStdlib to partOfStdlib should make the CI green.

Could you please make a PR (targeting the version-1-6 branch) which reverts and/or changes the stuff you mention?

@ringabout ringabout mentioned this pull request Oct 11, 2022
Closed
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nim-lang#20397; fixes stylecheck regression (nim-lang#20398)
0f458c7 
* fixes  nim-lang#20397; fixes stylecheck

* add testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--styleCheck:off does not work (and --styleCheck:hint is now the default?)

5 participants

@ringabout @metagn @narimiran @Varriount