Fix #20139 gcc error when constructing an object that has the same name in the same file name in 2 different directories #20564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same name in the same file name in 2 different directories
bung87
changed the title
Araq
reviewed
Oct 14, 2022
| c &= ".empty" | ||
| else: | ||
| if sfCompilerProc notin t.sym.flags: | ||
| c &= t.id |
Member
There was a problem hiding this comment.
It we use the id regardless there is no reason to do this convoluted way of doing things. Instead hashSym needs to take into account "module1" vs "module2" but that doesn't work either. Not sure what to do here.
Collaborator
Author
There was a problem hiding this comment.
before this module1 and module2 just hash its type kind, without if condition will produce duplicated TNimType, that's all I get.
Collaborator
There was a problem hiding this comment.
Could the lineInfo's FileIndex be used, or is that not temporally consistent enough?
Member
There was a problem hiding this comment.
Not consistent enough for my taste. There is a better way but it's pretty intrusive...
Member
|
Succeeded by #21274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20139
cause by
hashTypeof tyObjectnot cover all branch.