Skip to content

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented May 29, 2023

Motivation:

  • allow all formats to be included at once
  • test all formats in CI
  • no need for custom nixos-generators CLI
  • no need for custom nixos-generate nix function
  • just include a single module -> profit
  • test this pattern here first then contribute to nixpkgs

Done:

  • add module all-formats.nix exposing all formats within the current config under system.formats.<format>
  • adds a flake check to evaluate and build all formats for x86_64-linux and aarch64-linux
  • move some broken formats to ./formats-broken to fix later

Considerations:

  • expose formats under system.build instead of system.formats ?
  • expose formats as submodule options, so they can be modified on the fly without having to edit the format file

@DavHau
Copy link
Member Author

DavHau commented May 29, 2023

Now nix flake check goes OOM as it tries to evaluate all formats in a single session.
@Lassulus could we switch the project to hercules or garnix?

@Lassulus
Copy link
Collaborator

Now nix flake check goes OOM as it tries to evaluate all formats in a single session. @Lassulus could we switch the project to hercules or garnix?

uh, can we maybe do the checks a way so we don't need to run a big machine to test it? :D

@DavHau
Copy link
Member Author

DavHau commented May 30, 2023

Sure we can.

We don't necessarily need a big machine. It's just that a single nix eval goes OOM, as it doesn't garbage collect anything.
We could use nix-eval-jobs instead and use one process per attribute. That would make it faster as well potentially.

But why not just enable hercules? It's already available in the org and scales better.

@Lassulus
Copy link
Collaborator

ok, lets enable hercules and think later about lowering CI requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants