Mention the libc version changes in RELEASE_PROCEDURE.md #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@homu r+ |
Contributor
|
📌 Commit e9ede5d has been approved by |
Contributor
homu
added a commit
that referenced
this pull request
Sep 8, 2016
Mention the libc version changes in RELEASE_PROCEDURE.md r? @nix-rust/nix-maintainers
| - In `CHANGELOG.md`, rename the Unreleased section to the new version | ||
| followed by the date of the release. | ||
| - In `Cargo.toml`, update the version to the new version. | ||
| - In `Cargo.toml`, change the libc dependency to the latest version. |
Member
There was a problem hiding this comment.
add a mention that before committing we should make sure it builds and tests. well I guess this would be picked up by travis when the PR is made.
Contributor
Author
There was a problem hiding this comment.
I had the same idea. It's on my todo list!
Member
|
thanks! I had indeed left this out |
Contributor
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nix-rust/nix-maintainers