Skip to content

doc: rename warn-with-error to warn-with-error-code #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2020
Merged

doc: rename warn-with-error to warn-with-error-code #872

merged 1 commit into from
Jun 15, 2020

Conversation

dfabulich
Copy link
Contributor

@dfabulich dfabulich mentioned this pull request May 30, 2020
Closed
4 tasks
mhdawson
mhdawson approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 2c4ef25 into nodejs:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mmarchini mmarchini mmarchini approved these changes

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dfabulich @mmarchini @mhdawson