Skip to content

Moving to ClangCL on Windows for Node.js v24 #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Moving to ClangCL on Windows for Node.js v24 #4067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5db6a08
jenkins,win: release with clang from v24
StefanStojanovic Apr 11, 2025
253ee7f
jenkins,win: do not compile and test msvc from v24
StefanStojanovic Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ def buildExclusions = [
[ /vs2019/, releaseType, gte(21) ],
[ /vs2022-x86/, releaseType, gte(23) ],
[ /vs2022/, releaseType, lt(21) ],
[ /vs2022(?!_clang)(-\w+)?$/, releaseType, gte(24) ],
[ /vs2022_clang/, releaseType, lt(24) ],
// VS versions supported to compile Node.js - also matches labels used by test runners
[ /vs2015(-\w+)?$/, testType, gte(18) ],
[ /vs2017(-\w+)?$/, testType, gte(18) ],
[ /vs2019(-\w+)?$/, testType, gte(21) ],
[ /vs2022(-\w+)?$/, testType, lt(21) ],
[ /vs2022-x86$/, testType, gte(23) ], // x86 was dropped on Windows in v23
[ /vs2022(?!_clang)(-\w+)?$/, testType, gte(24) ], // MSVC was dropped on Windows in v24
[ /vs2022_clang(-\w+)?$/, testType, lt(24) ], // ClangCL support was added in v23
[ /COMPILED_BY-\w+-arm64$/, testType, lt(20) ], // run tests on arm64 for >=19
// VS versions supported to build add-ons
Expand Down