Add node-config-schema.json to expected files in v22.x
#4084
+24
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjohansebas
approved these changes
May 21, 2025
|
@aduh95 Can you fix the tests? |
RafaelGSS
approved these changes
Jul 15, 2025
richardlau
reviewed
Jul 15, 2025
| expectedStdout: | ||
| '... Checking R2 assets\n' + | ||
| '... Expecting a total of 47 assets for v22.x\n' + | ||
| '... 47 assets waiting in R2 staging\n' + | ||
| '... 0 assets already promoted in R2\n' + | ||
| ' \u001b[32m\u001b[1m✓\u001b[22m\u001b[39m Complete set of expected assets in place for v22.x\n', | ||
| setup: async function setup (context) { | ||
| context.rcloneLs[context.r2StagingDir] = await fixture('all-present-v22.12.0.json'); | ||
| context.rcloneLs[context.r2StagingDir] = await fixture('all-present-v22.16.0.json'); |
There was a problem hiding this comment.
Tests are failing.
e.g. https://github.com/nodejs/build/pull/4084/checks#step:4:120
# Subtest: Everything is in staging, nothing in dist, good to go
not ok 8 - Everything is in staging, nothing in dist, good to go
---
duration_ms: 0.897471
type: 'test'
location: '/home/runner/work/build/build/ansible/www-standalone/tools/promote/test/check_r2_assets.mjs:238:5'
failureType: 'testCodeFailure'
error: "ENOENT: no such file or directory, open '/home/runner/work/build/build/ansible/www-standalone/tools/promote/test/fixtures/all-present-v22.16.0.json'"
code: 'ENOENT'
stack: |-
async open (node:internal/fs/promises:633:25)
async readFile (node:internal/fs/promises:1237:14)
async setup (file:///home/runner/work/build/build/ansible/www-standalone/tools/promote/test/check_r2_assets.mjs:40:48)
async TestContext.<anonymous> (file:///home/runner/work/build/build/ansible/www-standalone/tools/promote/test/check_r2_assets.mjs:242:7)
async Test.run (node:internal/test_runner/test:1054:7)
async Suite.processPendingSubtests (node:internal/test_runner/test:744:7)
...
These fixtures are files in the ansible/www-standalone/tools/promote/test/fixtures directory and will either need to be replaced or the new files added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4040