lookup: add on-headers #1099
Open
lookup: add on-headers #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctcpip
reviewed
Jul 8, 2025
Signed-off-by: Sebastian Beltran <[email protected]>
|
I can't resolve the Prettier warning, it seems to be something outside of this PR. |
ctcpip
approved these changes
Jul 8, 2025
blakeembrey
approved these changes
Jul 8, 2025
UlisesGascon
approved these changes
Jul 9, 2025
There was a problem hiding this comment.
LGTM! The error in the CI are not related to this change.
I can't resolve the Prettier warning, it seems to be something outside of this PR.
@bjohansebas by running npm run lint:prettier:fix you can see that the changed files are test/reporter/test-reporter-tap.js and test/reporter/test-reporter-junit.js. So we can ignore it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this module monkey-patches
writeHead. It’s an important module in the Express ecosystem and probably in other key packages that need to use it as a hook forwriteHead. Adding it to CITGM wouldn’t be a bad idea while we wait for a solution in Node.js core that would allow us to deprecate this module.cc: @wesleytodd @UlisesGascon @blakeembrey @ctcpip
Checklist
npm testpasseshere