Add support for Babel 7.12 reexports #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Oct 21, 2020
| else break; | ||
|
|
||
| // `if (` IDENTIFIER$2 `in` EXPORTS_IDENTIFIER `&&` EXPORTS_IDENTIFIER `[` IDENTIFIER$2 `] ===` IDENTIFIER$1 `[` IDENTIFIER$2 `]) return` `;`? | ||
| if (ch === 105/*i*/ && source.startsWith('f ', pos + 1)) { |
There was a problem hiding this comment.
Note: I copied 'f ' from other parts of the code, but I think it could also be f(?
There was a problem hiding this comment.
Nice catch, yes we should probably allow the missing space.
guybedford
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Thanks so much for looking into this @nicolo-ribaudo! I'm going to go ahead and merge and release to upstream asap. And I thought you were working on scope problems there too :)
| else break; | ||
|
|
||
| // `if (` IDENTIFIER$2 `in` EXPORTS_IDENTIFIER `&&` EXPORTS_IDENTIFIER `[` IDENTIFIER$2 `] ===` IDENTIFIER$1 `[` IDENTIFIER$2 `]) return` `;`? | ||
| if (ch === 105/*i*/ && source.startsWith('f ', pos + 1)) { |
There was a problem hiding this comment.
Nice catch, yes we should probably allow the missing space.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Babel 7.12, we changed the output for
export * from "mod"to better simulate esm semantics:var _mod = require("mod"); Object.keys(_mod).forEach(function (key) { if (key === "default" || key === "__esModule") return; + if (key in exports && exports[key] === _mod[key]) return; Object.defineProperty(exports, key, { enumerable: true, get: function () { return _mod[key]; } }); });This PR updates
cjs-module-lexerto also recognize the new output.