Skip to content

Conversation

@avivkeller
Copy link
Member

@avivkeller avivkeller commented Oct 23, 2025

Fixes #189
Fixes #196


This PR has the issue generator run once a day, a look a week into the future

@avivkeller avivkeller changed the title feat(calendar): use ical feat(duplicates): run more often, skip duplicate issues Oct 23, 2025
@avivkeller avivkeller marked this pull request as ready for review October 29, 2025 19:34
@avivkeller avivkeller requested review from Copilot and ovflowd October 29, 2025 19:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to check for existing GitHub issues before creating duplicates, along with scheduling adjustments and calendar logic improvements. The changes allow the tool to detect if a meeting issue already exists and prevent duplicate creation unless explicitly forced.

  • Added a --force flag to allow bypassing duplicate detection
  • Implemented findIssueByTitle function to search for existing GitHub issues
  • Updated scheduling from weekly Monday runs to daily execution
  • Refined calendar week bounds calculation and error messaging

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/types.d.ts Added force boolean field to CLI configuration interface
src/github.mjs Implemented new findIssueByTitle function to search for existing issues by title
src/calendar.mjs Simplified getWeekBounds logic and updated error message from "current week" to "next week"
create-node-meeting-artifacts.mjs Added duplicate detection logic using findIssueByTitle and new --force CLI option
.github/workflows/create-meeting-artifacts-scheduled.yml Changed cron schedule from weekly (Mondays at 10:00) to daily (midnight)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Can we also do the same check for HackMD (can we buture PR)

@ovflowd
Copy link
Member

ovflowd commented Oct 30, 2025

My 2cents: Instead of exiting, it should skip either (or both) issue and HackMD creation depending on what exists and only update their contents.

The rwasoning is that if I run this after the issue or HackMD got already created I wish to be able to either create the msissing piece (issue or HackMD) and update the ones that already exist :)

@avivkeller
Copy link
Member Author

can we buture PR

I'm assuming this means "Can be future PR", and I will do this in a future PR

@avivkeller avivkeller merged commit 666c591 into nodejs:main Oct 30, 2025
8 checks passed
@avivkeller avivkeller deleted the run-more-often branch October 30, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meeting Created Too Soon Don't duplicate meeting generation

2 participants