-
-
Notifications
You must be signed in to change notification settings - Fork 44
feat(duplicates): run more often, skip duplicate issues #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2124e0f to
93c54ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to check for existing GitHub issues before creating duplicates, along with scheduling adjustments and calendar logic improvements. The changes allow the tool to detect if a meeting issue already exists and prevent duplicate creation unless explicitly forced.
- Added a
--forceflag to allow bypassing duplicate detection - Implemented
findIssueByTitlefunction to search for existing GitHub issues - Updated scheduling from weekly Monday runs to daily execution
- Refined calendar week bounds calculation and error messaging
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types.d.ts | Added force boolean field to CLI configuration interface |
| src/github.mjs | Implemented new findIssueByTitle function to search for existing issues by title |
| src/calendar.mjs | Simplified getWeekBounds logic and updated error message from "current week" to "next week" |
| create-node-meeting-artifacts.mjs | Added duplicate detection logic using findIssueByTitle and new --force CLI option |
| .github/workflows/create-meeting-artifacts-scheduled.yml | Changed cron schedule from weekly (Mondays at 10:00) to daily (midnight) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM! Can we also do the same check for HackMD (can we buture PR)
|
My 2cents: Instead of exiting, it should skip either (or both) issue and HackMD creation depending on what exists and only update their contents. The rwasoning is that if I run this after the issue or HackMD got already created I wish to be able to either create the msissing piece (issue or HackMD) and update the ones that already exist :) |
I'm assuming this means "Can be future PR", and I will do this in a future PR |
Fixes #189
Fixes #196
This PR has the issue generator run once a day, a look a week into the future