-
Couldn't load subscription status.
- Fork 19
feat(regexp): stricter regexps #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR makes regular expressions stricter by removing optional backticks and text patterns, addressing issue #378 and complementing a Node.js PR. The changes ensure that API documentation headings must include specific formatting requirements that were previously optional.
Key changes:
- Removes optional backticks from all regex patterns to require strict backtick formatting
- Simplifies event regex to require single quotes only
- Removes optional "Constructor:" and "Class property:" prefixes from their respective patterns
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
==========================================
- Coverage 74.56% 74.55% -0.02%
==========================================
Files 107 107
Lines 10459 10453 -6
Branches 681 681
==========================================
- Hits 7799 7793 -6
Misses 2658 2658
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes: #378
Companion: nodejs/node#60087
Makes the RegExp's more strict by removing all optional pieces.