feat: upgrade octokit to 16 #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the last GitHub API call not covered by our tests.
targos
reviewed
Aug 15, 2020
|
@targos I think I addressed everything :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved all remaining deprecations on v15 (convert everything to promises because callbacks were removed), upgraded to v16, fixed tests (the payload format of one request changed and nock was not matching it anymore). I already fixed some deprecations on v16, but didn't commit yet so that the PR is not overwhelming. With this PR we'll have access to createDispatchEvent, which means it will unblock #272.
P.S.: Each commit converts one callback-based function into Promises/async, so the best way to read this PR is going on each commit individually.