Skip to content

support bigint64/biguint64 in TypedArray::ElementSize() #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

support bigint64/biguint64 in TypedArray::ElementSize() #705

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89620dd
support bigint64/biguint64 in TypedArray::ElementSize()
fs-eire Apr 18, 2020
c99502e
resolve comments
fs-eire Apr 20, 2020
3b266f2
Update napi-inl.h
mhdawson Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions napi-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,10 @@ inline uint8_t TypedArray::ElementSize() const {
case napi_float32_array:
return 4;
case napi_float64_array:
#if (NAPI_VERSION > 5)
case napi_bigint64_array:
case napi_biguint64_array:
#endif // (NAPI_VERSION > 5)
return 8;
default:
return 0;
Expand Down