Add some Python 3 fixes to node-gyp #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2017
Closed
|
@refack Your review please? |
4 tasks
On Python 2, basestring is (unicode, str). On Python 3, basestring and unicode are gone, and there is only str.
refack
approved these changes
Oct 14, 2018
|
@rodrigc Thank you very much! |
refack
pushed a commit
that referenced
this pull request
Oct 14, 2018
#1150 Reviewed-By: Refael Ackermann <[email protected]>
refack
pushed a commit
that referenced
this pull request
Oct 14, 2018
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <[email protected]>
refack
pushed a commit
that referenced
this pull request
Oct 14, 2018
#1150 Reviewed-By: Refael Ackermann <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
#1150 Reviewed-By: Refael Ackermann <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
* assertEquals() with assertEqual() * iteritems() with items() for Python 3. * xrange() with range() for Python 3. #1150 Reviewed-By: Refael Ackermann <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Apr 24, 2019
#1150 Reviewed-By: Refael Ackermann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fully port node-gyp to Python 3,
but it provides some fixes which bring it in the direction which makes
doing a full port to Python 3 easier.