gyp: make cmake python3 compatible #1944
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
approved these changes
Oct 27, 2019
gengjiawen
force-pushed
the
cmake_py3
branch
2 times, most recently
from
31a4540 to
12fe565
Compare
richardlau
approved these changes
Oct 27, 2019
gengjiawen
changed the title
rvagg
pushed a commit
that referenced
this pull request
Oct 30, 2019
PR-URL: #1944 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
|
landed in d8e09a1 |
rvagg
pushed a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #1944 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1943
Checklist
npm install && npm testpassesDescription of change